kumaab commented on code in PR #1171:
URL: https://github.com/apache/ranger/pull/1171#discussion_r3846761446
##########
dev-support/ranger-docker/Dockerfile.ranger:
##########
@@ -26,12 +26,15 @@ ARG TARGETARCH
COPY ./dist/ranger-${RANGER_VERSION}-admin.tar.gz /home/ranger/dist/
COPY ./scripts/admin/ranger.sh ${RANGER_SCRIPTS}/
COPY ./scripts/admin/create-ranger-services.py ${RANGER_SCRIPTS}/
+COPY ./scripts/setup-ranger-shadow-group.sh ${RANGER_SCRIPTS}/
RUN tar xvfz /home/ranger/dist/ranger-${RANGER_VERSION}-admin.tar.gz
--directory=${RANGER_HOME} \
&& ln -s ${RANGER_HOME}/ranger-${RANGER_VERSION}-admin
${RANGER_HOME}/admin \
&& rm -f /home/ranger/dist/ranger-${RANGER_VERSION}-admin.tar.gz \
&& rm -f /opt/ranger/admin/install.properties \
&& mkdir -p /var/run/ranger /var/log/ranger /usr/share/java/ \
+ && chmod 755 ${RANGER_SCRIPTS}/setup-ranger-shadow-group.sh \
Review Comment:
Adding users/groups have moved to the base image:
https://github.com/apache/ranger-tools/blob/main/docker/Dockerfile , please see
this script:
https://github.com/apache/ranger-tools/blob/0e27092aedb0db01be54300f2936a6244e80ec6c/docker/create_users_and_groups.sh#L1
if a user like `shadow` is really required to be added.
##########
dev-support/ranger-docker/README.md:
##########
@@ -79,6 +79,10 @@ cd dev-support/ranger-docker
# To enable file based sync source for usersync do:
export ENABLE_FILE_SYNC_SOURCE=true
+# Unix authentication service is disabled by default in docker
(ENABLE_UNIX_AUTH=false).
Review Comment:
The comment may be removed, it's not relevant in docker deployments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
