vikaskr22 commented on code in PR #1188:
URL: https://github.com/apache/ranger/pull/1188#discussion_r3926051232
##########
kms/scripts/setup.sh:
##########
@@ -1112,6 +1114,37 @@ update_properties() {
updatePropertyToFilePy $propertyName
$newPropertyValue $to_file_kms_site
fi
fi
+ if [ "${ranger_kms_https_truststore_file}" != "" ] && [
"${ranger_kms_https_truststore_password}" != "" ]
+ then
+ propertyName=ranger.service.https.attrib.truststore.file
+ newPropertyValue="${ranger_kms_https_truststore_file}"
+ updatePropertyToFilePy $propertyName $newPropertyValue
$to_file_kms_site
+
+
policymgr_https_truststore_credential_alias=truststoreCredentialAlias
+
propertyName=ranger.service.https.attrib.truststore.credential.alias
+
newPropertyValue="${policymgr_https_truststore_credential_alias}"
+ updatePropertyToFilePy $propertyName $newPropertyValue
$to_file_kms_site
+
+ if [ "${keystore}" != "" ]
+ then
+
propertyName=ranger.service.https.attrib.truststore.pass
+ newPropertyValue="_"
+ updatePropertyToFilePy $propertyName
$newPropertyValue $to_file_kms_site
+ $PYTHON_COMMAND_INVOKER
ranger_credential_helper.py -l "cred/lib/*" -f "$keystore" -k
"$policymgr_https_truststore_credential_alias" -v
"$ranger_kms_https_truststore_password" -c 1
+ else
+
propertyName=ranger.service.https.attrib.truststore.pass
Review Comment:
I agree, security-admin approach is cleaner than KMS.
On overwrite if keystore is missing, isn't this expected to write the
password in the config file ? Both KMS & Admin will have same outcome, through
a different IF-Else branching. Am I missing anything ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
