spolavarpau1 commented on code in PR #1218:
URL: https://github.com/apache/ranger/pull/1218#discussion_r3963570345
##########
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java:
##########
@@ -513,11 +515,19 @@ private long getUsers(boolean computeDeletes) throws
Throwable {
}
if (config.isDeltaSyncEnabled()) {
- extendedUserSearchFilter = "(objectclass=" + userObjectClass +
")(|(uSNChanged>=" + deltaSyncUserTime + ")(modifyTimestamp>=" +
deltaSyncUserTimeStamp + "Z))";
+ if ("ad".equalsIgnoreCase(deltaSyncServerType)) {
Review Comment:
Add a private method that returns extendedUserSearchFilter value and move
the below logic there.
##########
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java:
##########
@@ -805,6 +806,18 @@ public boolean isGroupSearchFirstEnabled() {
return groupSearchFirstEnabled;
}
+ public String getDeltaSyncServerType() {
Review Comment:
I don't think we need this method. Instead have this logic in
LdapUserGroupBuilder.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
