vyommani commented on code in PR #1229: URL: https://github.com/apache/ranger/pull/1229#discussion_r4011593509
########## security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java: ########## Review Comment: Coverage gaps: (1) the old create-path mocks were removed but there's no test asserting create is still blocked for a KMS service; (2) delete-by-id / by-name where the KMS service sits alongside non-KMS services (current tests use a single-entry map); (3) the V2 RangerSecurityZoneChangeRequest path adding a KMS service; (4) findServiceDefTypeByServiceName returning null for an unknown service name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
