mneethiraj commented on code in PR #1347:
URL: https://github.com/apache/ranger/pull/1347#discussion_r4451417444
##########
security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java:
##########
@@ -177,7 +179,19 @@ public List<RangerServiceHeaderInfo> findServiceHeaders() {
ret = new ArrayList<>(results.size());
for (Object[] result : results) {
- ret.add(new RangerServiceHeaderInfo((Long) result[0], (String)
result[1], (String) result[2], (String) result[3], (Boolean) result[4]));
+ RangerServiceHeaderInfo svcHeader = new
RangerServiceHeaderInfo((Long) result[0], (String) result[1], (String)
result[2], (String) result[3], (Boolean) result[4]);
+ String adminUsers = (String) result[5];
+ String adminGroups = (String) result[6];
+
+ if (StringUtils.isNotBlank(adminUsers)) {
+
svcHeader.setAdminUsers(Arrays.asList(adminUsers.split(",")));
Review Comment:
You concern about exposing value of couple of service configurations remains
same though - it will not be identities of service admin users/groups but
instead it will be the service account identities. If this is unacceptable, we
will have to create a new permission to restrict access to these fields and
explicitly assign this permission to users. Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
