[
https://issues.apache.org/jira/browse/RANGER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297021#comment-14297021
]
Selvamohan Neethiraj commented on RANGER-209:
---------------------------------------------
-1 for the patch
[~ashishujjain] Couple of issues with the patch.
(a) When we generate the patch with 'git format-patch' command, it adds a
prefix to the file like
--- a/docs/src/site/site.xml
+++ b/docs/src/site/site.xml
So, this requires the patch command on the script to be fixed as '--dry-run
-p1' instead of '--dry-run -p0'. Otherwise, patch is NOT getting applied
(b) When it invoked maven command for install (line # 593 on the
test-patch.sh), it shows the maven command results on the stdout. Is it
expected behaviour? I was wondering if it should be redirected to /dev/null
(c) I see, patch directory (/tmp) and patch file name (/tmp/patch) are
hard-coded. How is this going to work in a multi-user environment where many
people might be testing their own patches ?
> Test Patch script for Ranger
> ----------------------------
>
> Key: RANGER-209
> URL: https://issues.apache.org/jira/browse/RANGER-209
> Project: Ranger
> Issue Type: Bug
> Affects Versions: 0.5.0
> Environment: Have test patch capability as part dev support, to test
> patches as part of Jenkins builds.
> Reporter: Ashish Singh
> Assignee: Ashish Singh
> Priority: Critical
> Fix For: 0.5.0
>
> Attachments: 0001-RANGER-209-Test-Patch-script-for-Ranger.patch
>
>
> Have the Test patch capability like other apache components. For example
> https://github.com/apache/hadoop-common/blob/branch-2/dev-support/test-patch.sh
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
