----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31587/#review74917 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 3, 2015, 7:21 a.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31587/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 7:21 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-278 > https://issues.apache.org/jira/browse/RANGER-278 > > > Repository: ranger > > > Description > ------- > > Validation test for services > > - Junits were added for ServiceREST only for create. Update and delete are > not testable currently without non-trivial refactoring. Hence, there is no > direct test of ServiceREST functionality. Of course, validator methods > called during update and delete have their junits. > > Fixes unrelaed to this bug: > > - Some pom files have hardcoded version in them. Version for child pom > should be inherited from that of parent pom as it the case for rest of child > poms. > - ServiceDBStore was missing Apache license boiler plate. > - LdapUserGroupBuilder file had an unused import that was causing a compile > error. > - Fixed maven build warnings due to missing findbugs version and unused/stale > eclipse m2e plugin. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31587/diff/ > > > Testing > ------- > > Added new junits for create/update/delete validation of services > Manual excercise of REST api to validate response and error messages(s). > > > Thanks, > > Alok Lal > >
