> On March 11, 2015, 8:28 a.m., Madhan Neethiraj wrote: > >
I missed that the test is calling validateConnectionConfigs(), and not testConnection(). So use of hardcoded hostnames would be fine here, as validateConnectionConfigs() will not try to connect to the namenode. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31874/#review76054 ----------------------------------------------------------- On March 10, 2015, 12:39 a.m., dilli dorai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31874/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 12:39 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-293 > https://issues.apache.org/jira/browse/RANGER-293 > > > Repository: ranger > > > Description > ------- > > RANGER-293: add server side checks for HDFS Repo connection properties > > > Diffs > ----- > > > hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java > 03f8124 > > hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/client/HdfsClientTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31874/diff/ > > > Testing > ------- > > Ran the newly added unit tests in > hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/client/HdfsClientTest.java > > Tested manually with ranger-admin ui > > > Thanks, > > dilli dorai > >
