----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31935/#review76403 -----------------------------------------------------------
Ship it! I will fix the password display issue. security-admin/scripts/dba_script.py <https://reviews.apache.org/r/31935/#comment123953> Password is displayed when typing. Hide password typing. security-admin/scripts/dba_script.py <https://reviews.apache.org/r/31935/#comment123954> Same comment as above, hide the password typing security-admin/scripts/dba_script.py <https://reviews.apache.org/r/31935/#comment123955> Same comment as above, hide the password typing - Velmurugan Periasamy On March 13, 2015, 11:33 a.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31935/ > ----------------------------------------------------------- > > (Updated March 13, 2015, 11:33 a.m.) > > > Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, > Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-302 > https://issues.apache.org/jira/browse/RANGER-302 > > > Repository: ranger > > > Description > ------- > > Need to provide separation of DBA/non-DBA part in installation script. > The current setup.sh script that comes with Ranger does not allow for > separating out DBA duties (creating schema, tablespace, etc) that require DBA > role from things that can be done as the ranger db user (non-DBA). > This may cause an issue because security policy may not allow them to access > the DB as DBA from the Ranger host. > > > Proposed Solution: > > 1] Provide a separate python scripts to do db setup ( dba_script.py ) > 2] Remove db setup part from existing setup.sh. > 3] Hence, going forward, even for Non-DBA users it is required to call the > script(dba_script.py) in part 1] as a prerequisite. > 4] If setup.sh is run before running the dba_script.py, setup.sh will exit > with failure. > > > Diffs > ----- > > security-admin/scripts/db_setup.py 1f05589 > security-admin/scripts/dba_script.py PRE-CREATION > security-admin/scripts/install.properties b9bcb20 > security-admin/scripts/setup.sh 85892ce > src/main/assembly/admin-web.xml 4a788e9 > > Diff: https://reviews.apache.org/r/31935/diff/ > > > Testing > ------- > > Tested locally by running dba_script.py first and then setup.sh. > Started Ranger and did sanity check. > > > Thanks, > > Gautam Borad > >
