-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32030/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-305
https://issues.apache.org/jira/browse/RANGER-305
Repository: ranger
Description
-------
policy resource flags about recursive/excludes are validated against policy
definitions.
Review does not work if I move the files - all files appear as new files! :(
There does not seem to be a way to specify --follow to the diff generator of
this review tool.
So I have moved the files back for review of changes and generated a patch with
old location. After chage review is done then I can move them and provide
another patch for commit. This has all latest changes.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java
281b32d
security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java
8e02f25
security-admin/src/main/java/org/apache/ranger/rest/RangerValidator.java
cec40fd
security-admin/src/main/java/org/apache/ranger/rest/RangerValidatorFactory.java
025595d
security-admin/src/test/java/org/apache/ranger/rest/TestRangerPolicyValidator.java
c3fdf30
security-admin/src/test/java/org/apache/ranger/rest/TestRangerServiceDefValidator.java
b621673
security-admin/src/test/java/org/apache/ranger/rest/TestRangerServiceValidator.java
3bad133
security-admin/src/test/java/org/apache/ranger/rest/TestRangerValidator.java
7da6672
security-admin/src/test/java/org/apache/ranger/rest/TestServiceRESTForValidation.java
d112b83
security-admin/src/test/java/org/apache/ranger/rest/ValidationTestUtils.java
6c71502
Diff: https://reviews.apache.org/r/32030/diff/
Testing
-------
New Junits added. Old junits updated to account for flag related assertions.
Thanks,
Alok Lal
