----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32548/#review77977 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 26, 2015, 8:24 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32548/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 8:24 p.m.) > > > Review request for ranger, Don Bosco Durai and Madhan Neethiraj. > > > Repository: ranger > > > Description > ------- > > Minor potential NPE issues, dead code, etc. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 839f1fc > security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java c4997ab > security-admin/src/main/java/org/apache/ranger/patch/BaseLoader.java > 61b46af > > security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java > ef9bc46 > security-admin/src/main/java/org/apache/ranger/service/XAssetService.java > 6c99705 > > security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java > 1355e95 > security-admin/src/main/java/org/apache/ranger/service/XGroupService.java > 580c31c > security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java > 146a953 > > security-admin/src/main/java/org/apache/ranger/service/XResourceService.java > b85ae55 > security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java > 7edce5b > security-admin/src/main/java/org/apache/ranger/service/XUserService.java > abac343 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/PolicyMgrUserGroupBuilder.java > 44932ad > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > 204a39c > > ugsync/src/main/java/org/apache/ranger/unixusersync/poc/RangerClientUserGroupMapping.java > 4ac922d > > unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/ConsolePromptCallbackHandler.java > 62a3d5a > > Diff: https://reviews.apache.org/r/32548/diff/ > > > Testing > ------- > > Built clean, ran unit tests, and ranger admin GUI. > > > Thanks, > > Abhay Kulkarni > >
