----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32649/#review78266 -----------------------------------------------------------
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java <https://reviews.apache.org/r/32649/#comment126782> The fix will be to change #298 to "if(StringUtils.isEmpty(column))" (remove call to .trim()). With the current fix, line #303 will be executed when column == null. This should not happen. knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java <https://reviews.apache.org/r/32649/#comment126783> Compared to the earlier code, the result is different when knoxServiceList == null && serviceName != null. Please review. plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java <https://reviews.apache.org/r/32649/#comment126784> topologyList is not assigned to. Please review. security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java <https://reviews.apache.org/r/32649/#comment126785> Please review if null return is expected/handled from this method. Other error conditions result in exception being thrown. security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java <https://reviews.apache.org/r/32649/#comment126786> this "if" block is to handle "empty" policy name condition. The fix seems to reverse this. Please review. security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java <https://reviews.apache.org/r/32649/#comment126787> After moving from iterating keySet to entrySet, using entry.getValue() would be better here, instead of visibilityMap.get(key). Please review the following block as well. - Madhan Neethiraj On March 30, 2015, 9:50 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32649/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 9:50 p.m.) > > > Review request for ranger, Don Bosco Durai and Madhan Neethiraj. > > > Repository: ranger > > > Description > ------- > > This patch fixes potential NPE, logic flow problems leading to dead code > issues, and other clean-ups so as to comply with better code practices. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 2e4a79e > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 191b370 > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java > 56ca075 > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerDefaultResourceMatcher.java > c8d10d6 > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java > 3640b38 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > b1a1b16 > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java > 3513bcb > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseAuthUtilsImpl.java > e42d096 > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java > e3ad68d > > hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseResourceMgr.java > 8682d18 > > hdfs-agent/src/main/java/org/apache/hadoop/hdfs/server/namenode/RangerFSPermissionChecker.java > 592e77f > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/agent/HadoopAuthClassTransformer.java > 2b7a63e > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > 72e6652 > > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java > 4ea16df > jisql/src/main/java/org/apache/util/sql/Jisql.java 62da3c1 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 9b1ff67 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java > 274b5f8 > > knox-agent/src/main/java/org/apache/ranger/authorization/knox/RangerPDPKnoxFilter.java > 9809b3f > > knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java > 9f7a955 > lookup-client/src/main/java/org/apache/ranger/knox/client/KnoxClient.java > e9b6c33 > > plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java > aff04ed > > plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java > 35d95e6 > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 4750081 > security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java fb918c5 > security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 420b37d > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 3ed6ff3 > security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java > 2c93f8d > security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java > 43d3784 > security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java > b340625 > security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 462671a > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java 082b2f8 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 5efa2c3 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java > 9febc23 > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java > 1db4779 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java > ca9f7d4 > security-admin/src/main/java/org/apache/ranger/service/XAssetService.java > 1d6f42c > > security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java > c00ca74 > security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java > 34109ae > > security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java > 9dffbcb > > security-admin/src/main/java/org/apache/ranger/service/XRepositoryService.java > fcaa4d8 > > security-admin/src/main/java/org/apache/ranger/service/XResourceService.java > 1faec21 > security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java > 3c3ac64 > security-admin/src/main/java/org/apache/ranger/service/XUserService.java > c70fbb8 > security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 60ef902 > > storm-agent/src/main/java/org/apache/ranger/authorization/storm/authorizer/RangerStormAuthorizer.java > eb15b69 > > storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormResourceMgr.java > 3a9f1ac > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java > 011170c > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > 6e98b34 > > unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java > 0280464 > > Diff: https://reviews.apache.org/r/32649/diff/ > > > Testing > ------- > > Built clean and ran unit tests. > > > Thanks, > > Abhay Kulkarni > >
