----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32671/#review78312 -----------------------------------------------------------
agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json <https://reviews.apache.org/r/32671/#comment126847> To enable easier handling of resource additions, it is recommended to use levels like 10, 20 i.e. spaced. agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json <https://reviews.apache.org/r/32671/#comment126849> matcherOptions value is now specified as JSON map. Please refer other service-def for samples and update. agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json <https://reviews.apache.org/r/32671/#comment126850> Or is it to represent 'Delegated Admin' in Ranger? If yes, please remove 'admin' as an accessType. If 'admin' is a permission in Solr - does this permission include (imply) other permissions as well? If yes, please add 'impliedAccessTypes' (please refer hbase service-def) plugin-solr/conf/ranger-solr-audit-changes.cfg <https://reviews.apache.org/r/32671/#comment126855> No Kafka properties and few Solr properties are missing (compared to other plugins). Please review. plugin-solr/conf/ranger-solr-audit.xml <https://reviews.apache.org/r/32671/#comment126852> properties for Solr and Kafka destinations missing. Please review. plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java <https://reviews.apache.org/r/32671/#comment126860> Please check this resource-name (column) with the one given in service-def (field). - Madhan Neethiraj On March 31, 2015, 12:25 a.m., Don Bosco Durai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32671/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 12:25 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-178 > https://issues.apache.org/jira/browse/RANGER-178 > > > Repository: ranger > > > Description > ------- > > RANGER-178 - Ranger Admin server side code for Solr plugin service > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json > PRE-CREATION > plugin-solr/.gitignore PRE-CREATION > plugin-solr/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION > plugin-solr/conf/ranger-policymgr-ssl.xml PRE-CREATION > plugin-solr/conf/ranger-solr-audit-changes.cfg PRE-CREATION > plugin-solr/conf/ranger-solr-audit.xml PRE-CREATION > plugin-solr/conf/ranger-solr-security-changes.cfg PRE-CREATION > plugin-solr/conf/ranger-solr-security.xml PRE-CREATION > plugin-solr/pom.xml PRE-CREATION > plugin-solr/scripts/install.properties PRE-CREATION > plugin-solr/scripts/solr-plugin-install.properties PRE-CREATION > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > PRE-CREATION > > plugin-solr/src/main/java/org/apache/ranger/services/solr/RangerServiceSolr.java > PRE-CREATION > > plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java > PRE-CREATION > > plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrConnectionMgr.java > PRE-CREATION > pom.xml a93cd73 > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 8e6aa3f > security-admin/src/main/resources/sample.xa_system.properties 8043ef8 > src/main/assembly/plugin-solr.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/32671/diff/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Don Bosco Durai > >
