----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32552/#review78321 -----------------------------------------------------------
Ship it! hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java <https://reviews.apache.org/r/32552/#comment126867> Variables instantiated/initialized from line #431 to #437 seems to be used only in Debug log. If true, move these to inside LOG.isDebugEnabled() block. - Madhan Neethiraj On March 31, 2015, 2:57 a.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32552/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 2:57 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-238 > https://issues.apache.org/jira/browse/RANGER-238 > > > Repository: ranger > > > Description > ------- > > Filter Hive database and table listing based on permissions > > Some additional changes submitted as part of the above > - Fixed a problem with "any" access logic. New tests were added to validate > this functionality. > - Removed explicit groupid of child projects. > - Removed redefinition depedencies version if specified in parent pom. > - Added generated code directory to .gitignore. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > d5332b2 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > b4175e2 > agents-common/src/test/resources/policyengine/test_policyengine_hive.json > 2ac90ae > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java > 7110861 > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > 72e6652 > > Diff: https://reviews.apache.org/r/32552/diff/ > > > Testing > ------- > > System tests to follow in another patch. > > > Thanks, > > Alok Lal > >
