-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32746/
-----------------------------------------------------------
(Updated April 1, 2015, 6:44 p.m.)
Review request for ranger.
Changes
-------
Addressed review comments.
- Added new tests for additional scenarios (update) and flags (null and
excludes)
Bugs: RANGER-354
https://issues.apache.org/jira/browse/RANGER-354
Repository: ranger
Description
-------
Policy validation: Prevent creation/update of policies for the same resource
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/RangerObjectFactory.java
PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyResourceSignature.java
PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
f5d6bff
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java
7bf744e
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerObjectFactory.java
PRE-CREATION
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyResourceSignature.java
PRE-CREATION
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java
e0f68ad
Diff: https://reviews.apache.org/r/32746/diff/
Testing
-------
- Existing junits pass
- New junits tests added for unit and integration testing
Thanks,
Alok Lal
