----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32873/#review78927 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java <https://reviews.apache.org/r/32873/#comment128027> Please add null checks for serviceDef.getId()/id. security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java <https://reviews.apache.org/r/32873/#comment128025> Please add null checks for serviceDef.getName()/ name. security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java <https://reviews.apache.org/r/32873/#comment128026> Please add null checks for name/serviceDef. security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java <https://reviews.apache.org/r/32873/#comment128028> Please add null checks for service.getId()/id. security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java <https://reviews.apache.org/r/32873/#comment128029> Please add null checks for service.getName()/name. security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java <https://reviews.apache.org/r/32873/#comment128030> Please add null checks for service/name. security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java <https://reviews.apache.org/r/32873/#comment128031> Please add null checks for policy.getId()/id security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java <https://reviews.apache.org/r/32873/#comment128032> I think we should retrieve the policy for the given serviceName and policyName; and validate that the given policy matches. - Madhan Neethiraj On April 6, 2015, 7:28 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32873/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 7:28 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, and > Ramesh Mani. > > > Repository: ranger > > > Description > ------- > > Public REST APIs are defined and implemented for a full access to Ranger > objects for specifying security policies. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java ece20b1 > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/32873/diff/ > > > Testing > ------- > > Used a set of curl scripts to unit test each of the publically available REST > API. > > > Thanks, > > Abhay Kulkarni > >
