----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33095/#review79771 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java <https://reviews.apache.org/r/33095/#comment129322> Please investigate if the Evaluators can be constructed in one go; instead of creating empty object and then invoking init() on it. It will help ensuring the contained objects remain invariant with appropriate Java language constructs. agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java <https://reviews.apache.org/r/33095/#comment129317> BasePlugin methods which can be invoked from a component directly need to ensure that the policy-engine object used to service the authorization request is consistent within the scope of that request, because, component can potentially invoke these methods in a multiple threads. All other methods which need to use policy-engine (such as enricherRequests()) need to accept policy-engine object as a formal argument, and not use policy-engine member object. - Abhay Kulkarni On April 10, 2015, 10:18 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33095/ > ----------------------------------------------------------- > > (Updated April 10, 2015, 10:18 p.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, dilli dorai, Gautam > Borad, Abhay Kulkarni, Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-390 > https://issues.apache.org/jira/browse/RANGER-390 > > > Repository: ranger > > > Description > ------- > > RangerPolicyDb implementation merged with RangerPolicyEngine > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyDb.java > d07afe3 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyDbCache.java > bfa71b8 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java > da83838 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCache.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > f09ad70 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEvaluatorFacade.java > 862cd1a > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > b1d37ca > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java > 36273eb > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 052bb88 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerOptimizedPolicyEvaluator.java > 7ddd155 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > 18ec248 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 5c37c7b > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > 04bc798 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyDb.java > 37b8e9c > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 7ebd34e > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseFactory.java > 97e70ec > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 8b3834e > > Diff: https://reviews.apache.org/r/33095/diff/ > > > Testing > ------- > > Verified that build and unit test succeeded. > > > Thanks, > > Madhan Neethiraj > >
