----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33149/#review79988 -----------------------------------------------------------
Ship it! Please see the review comment; other changes look good. ugsync/src/main/java/org/apache/ranger/unixusersync/poc/ListUserTest.java <https://reviews.apache.org/r/33149/#comment129711> Looks like this class may not be used in the product. If yes, can this be removed? - Madhan Neethiraj On April 14, 2015, 12:44 a.m., dilli dorai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33149/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 12:44 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan > Neethiraj, and Ramesh Mani. > > > Bugs: RANGER-344 > https://issues.apache.org/jira/browse/RANGER-344 > > > Repository: ranger > > > Description > ------- > > RANGER-344: Cleanup/fixes to comply with best practices > > > Diffs > ----- > > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java > 5b959a0 > ugsync/src/main/java/org/apache/ranger/unixusersync/poc/ListUserTest.java > d7424f1 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > acbee13 > > Diff: https://reviews.apache.org/r/33149/diff/ > > > Testing > ------- > > Built and ran unit tests without errors. > > > Thanks, > > dilli dorai > >
