----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34111/#review83417 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On May 12, 2015, 3:44 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34111/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 3:44 p.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-470 > https://issues.apache.org/jira/browse/RANGER-470 > > > Repository: ranger > > > Description > ------- > > Renamed attribute 'id' in service-def inner objects to 'itemId' - to avoid > confusion with DB object id > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java > cd634b8 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java > c57e5fc > agents-common/src/main/resources/service-defs/ranger-servicedef-hbase.json > 2887e5f > agents-common/src/main/resources/service-defs/ranger-servicedef-hdfs.json > 75deeb4 > agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json > 6d1cab5 > agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json > 98501a2 > agents-common/src/main/resources/service-defs/ranger-servicedef-kms.json > 260d351 > agents-common/src/main/resources/service-defs/ranger-servicedef-knox.json > e437e6b > agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json > 2b9fa1a > agents-common/src/main/resources/service-defs/ranger-servicedef-storm.json > 99d9dd1 > agents-common/src/main/resources/service-defs/ranger-servicedef-yarn.json > c178e7e > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java > 54bbdf1 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/ValidationTestUtils.java > 549a94a > security-admin/db/mysql/patches/009-updated_schema.sql 40e71ca > security-admin/db/oracle/patches/009-updated_schema.sql cdbdeb8 > security-admin/db/postgres/xa_core_db_postgres.sql 10f614b > security-admin/db/sqlserver/xa_core_db_sqlserver.sql 11c315d > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 7f83562 > security-admin/src/main/java/org/apache/ranger/entity/XXAccessTypeDef.java > ba2f2d2 > > security-admin/src/main/java/org/apache/ranger/entity/XXContextEnricherDef.java > 27992e4 > security-admin/src/main/java/org/apache/ranger/entity/XXEnumDef.java > aea4f3e > security-admin/src/main/java/org/apache/ranger/entity/XXEnumElementDef.java > a4532f5 > > security-admin/src/main/java/org/apache/ranger/entity/XXPolicyConditionDef.java > b9e73c4 > security-admin/src/main/java/org/apache/ranger/entity/XXResourceDef.java > 5974033 > > security-admin/src/main/java/org/apache/ranger/entity/XXServiceConfigDef.java > a6650d2 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java > d3f0d7b > > Diff: https://reviews.apache.org/r/34111/diff/ > > > Testing > ------- > > Verified that the new column 'item_id' is created for service-def inner > object tables and this column is populated during service-de creation. > > > Thanks, > > Madhan Neethiraj > >
