> On May 14, 2015, 9:24 a.m., Madhan Neethiraj wrote: > > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveConnectionMgr.java, > > line 92 > > <https://reviews.apache.org/r/34196/diff/1/?file=958761#file958761line92> > > > > When does this recursion terminate? Please ensure that this doesn't > > get into runaway recursion.
Yes, since connection is removed from the map before recursive call the loop would terminate. - Alok ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34196/#review83784 ----------------------------------------------------------- On May 13, 2015, 11:05 p.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34196/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 11:05 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Ramesh Mani. > > > Bugs: RANGER-477 > https://issues.apache.org/jira/browse/RANGER-477 > > > Repository: ranger > > > Description > ------- > > - Fixed a bug in how Hive client connection is stored in the cache > - Changed the cache to use ConcurrentMap to eliminate Coverity reported > issues. > - Changed a isEmpty to isBlank as before last fix made to coverity code was > during trim on a potentially null string. > > > Diffs > ----- > > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > 98532a9 > > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveConnectionMgr.java > a5eda0b > > Diff: https://reviews.apache.org/r/34196/diff/ > > > Testing > ------- > > Existing tests work. > > > Thanks, > > Alok Lal > >
