----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34180/#review84328 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java <https://reviews.apache.org/r/34180/#comment135539> "lookup" ==> "resource.lookup" (from line# 345). A better approach would be to pass the default value as an argument to this method (from line # 345 and #349). security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml <https://reviews.apache.org/r/34180/#comment135540> 1 seconds seems to be too low. Can you please try in few services (hdfs, hive, hbase, ..) and see if the lookup returns within 1 second? Do you see any issues with a higher value, say 3 seconds? - Madhan Neethiraj On May 19, 2015, 7:53 a.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34180/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 7:53 a.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Ramesh Mani. > > > Bugs: RANGER-265 > https://issues.apache.org/jira/browse/RANGER-265 > > > Repository: ranger > > > Description > ------- > > Lookup and validation Calls to serices are done asynchrenously. Default > Timeout value is distributed with the default-site-config with a provision to > specify service-level override. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 8498fbf > > security-admin/src/main/java/org/apache/ranger/common/LookupConfigurator.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/common/PropertiesHelper.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/common/TimedExecutorConfigurator.java > PRE-CREATION > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 571d2a1 > > security-admin/src/test/java/org/apache/ranger/common/TestLookupConfigurator.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/34180/diff/ > > > Testing > ------- > > 1. Resouce lookup for hive, hdfs and hbase tested. Time taken to schedule > and execute the lookup calls looks fine. > 2. New test added to assert the executor behaviors around: > -- successful execution > -- timeout during or waiting for execution > -- rejection due to queue capacity limit > > > Thanks, > > Alok Lal > >
