----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34878/#review85944 -----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java <https://reviews.apache.org/r/34878/#comment137760> Need to move this above the if condition agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditQueue.java <https://reviews.apache.org/r/34878/#comment137761> Need to remove this method. Got added by mistake agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditQueue.java <https://reviews.apache.org/r/34878/#comment137762> Need to remove this method. Got added by mistake agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditQueue.java <https://reviews.apache.org/r/34878/#comment137763> Need to remove this method. Got added by mistake agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java <https://reviews.apache.org/r/34878/#comment137764> Should be resp.toString(), because response could be null - Don Bosco Durai On June 1, 2015, 6:50 a.m., Don Bosco Durai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34878/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 6:50 a.m.) > > > Review request for ranger, Madhan Neethiraj and Selvamohan Neethiraj. > > > Bugs: RANGER-397 > https://issues.apache.org/jira/browse/RANGER-397 > > > Repository: ranger > > > Description > ------- > > RANGER-397 Port log4j audit provider to V3 implementation > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/DBAuditDestination.java > 8cece4e > > agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java > a132cdf > > agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java > 67382a9 > > agents-audit/src/main/java/org/apache/ranger/audit/destination/Log4JAuditDestination.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java > ac522cd > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java > c3a05ce > > agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java > 09335c7 > > agents-audit/src/main/java/org/apache/ranger/audit/provider/Log4jAuditProvider.java > 0402de2 > > agents-audit/src/main/java/org/apache/ranger/audit/provider/MultiDestAuditProvider.java > 4c1593a > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditBatchQueue.java > 80d7853 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java > 1b9a921 > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditQueue.java > e873459 > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > 9d103bb > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > 0d38224 > > Diff: https://reviews.apache.org/r/34878/diff/ > > > Testing > ------- > > Manual testing > > > Thanks, > > Don Bosco Durai > >
