-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35105/#review86746
-----------------------------------------------------------



agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java
<https://reviews.apache.org/r/35105/#comment138809>

    setUGI(), getUGI(), getUGIVersion(), getSubject() - these names are too 
generic to be placed in MiscUtil. Either rename the methods to something like 
getProcessUGI() or move to a different location. It will be best if these 
methods (that save the logged-in user status) can be removed!!


- Madhan Neethiraj


On June 4, 2015, 11:55 p.m., Don Bosco Durai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35105/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 11:55 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-261
>     https://issues.apache.org/jira/browse/RANGER-261
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-261 Fix audit to HDFS in Kerberos environment
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  404108d 
> 
> Diff: https://reviews.apache.org/r/35105/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Don Bosco Durai
> 
>

Reply via email to