----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35111/#review86773 -----------------------------------------------------------
Ship it! agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java <https://reviews.apache.org/r/35111/#comment138845> "not setting it" - should ugiLoginUser be set? Same for subjectLoginUser as well.. agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditAsyncQueue.java <https://reviews.apache.org/r/35111/#comment138851> MiscUtil.getUGILoginUser() - can this be null? If yes, please add null check here. agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditBatchQueue.java <https://reviews.apache.org/r/35111/#comment138854> Add null check for MiscUti.getUGULoginUser() - please see my earlier comment. agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java <https://reviews.apache.org/r/35111/#comment138856> if ugiVersion is no more used, please remove. agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java <https://reviews.apache.org/r/35111/#comment138857> null check for MiscUtil.getUGILoginUser() - Madhan Neethiraj On June 5, 2015, 5 a.m., Don Bosco Durai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35111/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 5 a.m.) > > > Review request for ranger, Madhan Neethiraj and Selvamohan Neethiraj. > > > Bugs: RANGER-261 > https://issues.apache.org/jira/browse/RANGER-261 > > > Repository: ranger > > > Description > ------- > > RANGER-261 Fix audit to HDFS in Kerberos environment > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java > e79e42d > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java > f02ba62 > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > abb0a90 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditAsyncQueue.java > 47480da > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditBatchQueue.java > 2361bbf > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java > 9c10c54 > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditQueue.java > 057f192 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditSummaryQueue.java > f1ce799 > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > 844d0ac > agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json > 4752eff > agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json > 107b5d6 > embeddedwebserver/scripts/ranger-admin-services.sh 6931dbf > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java > f6fa8bd > kms/scripts/ranger-kms f0fa1b4 > plugin-kafka/conf/kafka-ranger-env.sh 2ec122d > > plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java > 0d0cffc > > security-admin/src/main/java/org/apache/ranger/service/filter/RangerRESTAPIFilter.java > 21536ac > > Diff: https://reviews.apache.org/r/35111/diff/ > > > Testing > ------- > > Manual test > > > Thanks, > > Don Bosco Durai > >
