----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35328/#review87494 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java <https://reviews.apache.org/r/35328/#comment139842> Consider printing the number of condition evaluators created in the init() call as part of exit debug message. agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java <https://reviews.apache.org/r/35328/#comment139837> Indentation! agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java <https://reviews.apache.org/r/35328/#comment139838> getIsAllowed() needs to be checked? We don't have deny policy, so is this check needed? agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java <https://reviews.apache.org/r/35328/#comment139839> Should getIsAllowed() value matter in allow decision? agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java <https://reviews.apache.org/r/35328/#comment139840> Can the serviceDef be inferred from policy? In that case, there is no need to have a separate setServiceDef(). Also, consider 'other' pattern of having all necessary objects provided in the constructor and no set methods. May be it is more appropriate here. agents-common/src/test/resources/policyengine/test_policyengine_conditions.json <https://reviews.apache.org/r/35328/#comment139835> Is there supposed to be a test for accessType "alter"? agents-common/src/test/resources/policyengine/test_policyengine_hbase.json <https://reviews.apache.org/r/35328/#comment139832> "table":"table" should be "parent":"table" - Abhay Kulkarni On June 10, 2015, 11:05 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35328/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 11:05 p.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-546 > https://issues.apache.org/jira/browse/RANGER-546 > > > Repository: ranger > > > Description > ------- > > fix in custom conditions evaluation > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerSimpleMatcher.java > 48f806d > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java > 85e69f1 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyItemEvaluator.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 9233f8d > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerOptimizedPolicyEvaluator.java > 26d5223 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > 9fe523a > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java > PRE-CREATION > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 38b7302 > > agents-common/src/test/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluatorTest.java > 943b76a > > agents-common/src/test/resources/policyengine/test_policyengine_conditions.json > PRE-CREATION > agents-common/src/test/resources/policyengine/test_policyengine_hbase.json > 338d4cf > > Diff: https://reviews.apache.org/r/35328/diff/ > > > Testing > ------- > > Added unit tests to verify that custom conditions are evaluated correctly > > > Thanks, > > Madhan Neethiraj > >
