----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35865/#review89403 -----------------------------------------------------------
Ship it! Ship It! - Alok Lal On June 25, 2015, 2:12 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35865/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 2:12 a.m.) > > > Review request for ranger, Alok Lal, Gautam Borad, Abhay Kulkarni, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-568 > https://issues.apache.org/jira/browse/RANGER-568 > > > Repository: ranger > > > Description > ------- > > fixed RangerTimeOfDayMatcher condition to handle 12am/12pm correctly. updated > unit tests > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTimeOfDayMatcher.java > 3ddb250 > > agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerTimeOfDayMatcherTest.java > e894d98 > > Diff: https://reviews.apache.org/r/35865/diff/ > > > Testing > ------- > > Added new unit test cases to cover the failing time ranges. > > > Thanks, > > Madhan Neethiraj > >
