----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35669/#review93353 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On July 28, 2015, 9:14 p.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35669/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 9:14 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-560 > https://issues.apache.org/jira/browse/RANGER-560 > > > Repository: ranger > > > Description > ------- > > Changes made to policy validation only to return user friendly messages: > - Each error has distinct code. > - Message generated is for human consumption. > - Multiple error messages are serialized in a user friendly manner > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java > 84f750d > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationFailureDetails.java > 015203a > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestValidationFailureDetails.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35669/diff/ > > > Testing > ------- > > New junits, changes to existing junits. > Manual testing invoking REST api > > > Thanks, > > Alok Lal > >
