-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37939/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 8:56 p.m.)
Review request for ranger, Gautam Borad and Abhay Kulkarni.
Changes
-------
Uploading the last review, as the review couldn't show diff in the earlier
upload. To see the updates, select 1 and 3 as the revisions.
Bugs: RANGER-274
https://issues.apache.org/jira/browse/RANGER-274
Repository: ranger
Description
-------
- TagREST updates:
- fix incorrect URLs
- new methods deleteTagDefByGuid(), getTagDef(id), getTagDefByGuid(),
getAllServiceResources(), deleteTagResourceMap(), deleteTagResourceMapByGuid(),
getTagResourceMap(), getTagResourceMapByGuid(), getTagResourceMap(tagGuid,
resourceGuid), getAllTagResourceMaps()
- Fix: TagDBStore.deleteTagDef() to delete attributeDefs
- Renamed: RangerTag.attributeValues ==> RangerTag.attributes
- Renamed: RangerScriptExecutionContext.getAttributeValues() ==>
RangerScriptExecutionContext.getAttributes()
- Renamed: RangerServiceResource.resourceSpec ==>
RangerServiceResource.resourceElements
- Renamed: Inner class: ServiceResourceSpecSerializer ==>
ServiceResourceSerializer
- Added: TagStore.getTagResourceMapByGuid()
- Added: TagFileStore.getTagResourceMapByGuid()
- Added: TagDBStore.getTagResourceMapByGuid()
- Added: TagValidator.preDeleteTagResourceMapById()
- Added: TagValidator.preDeleteTagResourceMapByGuid()
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
6fe5262
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagProvider.java
83600c9
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceResource.java
c9e07eb
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTag.java
6e4685a
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagResourceMap.java
8fca4c7
agents-common/src/main/java/org/apache/ranger/plugin/store/RangerServiceResourceSignature.java
1affec5
agents-common/src/main/java/org/apache/ranger/plugin/store/TagPredicateUtil.java
de48240
agents-common/src/main/java/org/apache/ranger/plugin/store/TagStore.java
f9d1086
agents-common/src/main/java/org/apache/ranger/plugin/store/TagValidator.java
8c2b230
agents-common/src/main/java/org/apache/ranger/plugin/store/file/TagFileStore.java
0b4f0ca
agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java
743df88
agents-common/src/test/java/org/apache/ranger/plugin/store/TestTagStore.java
5424158
agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json
f7fab3d
security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql
629d1c4
security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java 08a632c
security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceDao.java
7e29e36
security-admin/src/main/java/org/apache/ranger/db/XXTagDefDao.java f18fea8
security-admin/src/main/java/org/apache/ranger/db/XXTagResourceMapDao.java
75d04ae
security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 1d8493a
security-admin/src/main/java/org/apache/ranger/rest/TagREST.java b06f5cc
security-admin/src/main/java/org/apache/ranger/rest/TagRESTConstants.java
91525df
security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java
a81b981
security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceServiceBase.java
1510ffa
security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java
462b781
security-admin/src/main/java/org/apache/ranger/service/RangerTagResourceMapService.java
6894e4e
security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java
3d7ea24
security-admin/src/main/java/org/apache/ranger/service/RangerTagServiceBase.java
359e7ae
security-admin/src/main/resources/META-INF/jpa_named_queries.xml a05e0bd
Diff: https://reviews.apache.org/r/37939/diff/
Testing
-------
Verified that TagREST methods work correctly.
Thanks,
Madhan Neethiraj
