-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39029/#review101560
-----------------------------------------------------------



security-admin/contrib/audit_hdfs_folders/create_hdfs_folders_for_audit_non_secure.sh
 (line 24)
<https://reviews.apache.org/r/39029/#comment158995>

    Instead of hardcoding "hdfs:hdfs", consider using a variable like 
${HDFS_USER}:${HDFS_GROUP}. Please review account for other services as well.


- Madhan Neethiraj


On Oct. 5, 2015, 11:19 p.m., Don Bosco Durai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39029/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 11:19 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Madhan Neethiraj, Selvamohan 
> Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-173
>     https://issues.apache.org/jira/browse/RANGER-173
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> There are 2 scripts now. One for secure and other for non-secure. The reason 
> being, in secure mode Ranger KMS logs audit as user HTTP and in non-secure 
> mode it logs audit as user kms
> 
> 
> Diffs
> -----
> 
>   
> security-admin/contrib/audit_hdfs_folders/create_hdfs_folders_for_audit_non_secure.sh
>  PRE-CREATION 
>   
> security-admin/contrib/audit_hdfs_folders/create_hdfs_folders_for_audit_secure.sh
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39029/diff/
> 
> 
> Testing
> -------
> 
> Tested manually on both secure and non-secure mode
> 
> 
> Thanks,
> 
> Don Bosco Durai
> 
>

Reply via email to