----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39103/#review101842 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On Oct. 7, 2015, 11:43 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39103/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 11:43 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-683 > https://issues.apache.org/jira/browse/RANGER-683 > > > Repository: ranger > > > Description > ------- > > Fixed the earlier implementation that allowed access if the user has > permission for the tag even though a resource-based policy denied the access > > > Diffs > ----- > > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hdfs.json > ed42d5c > > Diff: https://reviews.apache.org/r/39103/diff/ > > > Testing > ------- > > - added unit tests to cover the following combinations: > > ------------------------------------------- > | Resource-policy | Tag-policy | Result | > |-----------------|------------|-----------| > | Allowed | Allowed | Allowed | > |-----------------|------------|-----------| > | Allowed | Denied | Denied | > |-----------------|------------|-----------| > | Allowed | No policy | Allowed | > |-----------------|------------|-----------| > | Denied | Allowed | Denied | > |-----------------|------------|-----------| > | Denied | Denied | Denied | > |-----------------|------------|-----------| > | Denied | No policy | Denied | > |-----------------|------------|-----------| > | No policy | Allowed | Allowed | > |-----------------|------------|-----------| > | No policy | Denied | Denied | > |-----------------|------------|-----------| > | No policy | No policy | No result | > |-----------------|------------|-----------| > > > Thanks, > > Madhan Neethiraj > >
