----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39101/#review101829 -----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java (line 101) <https://reviews.apache.org/r/39101/#comment159327> Notion of 'configProps' might be useful for other destinations as well. Consider moving this to base class AuditDestination. agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java (line 145) <https://reviews.apache.org/r/39101/#comment159328> Can out.close() throw exception? If yes, move the call to addDeferredCount() after out.close() call. hbase-agent/conf/ranger-hbase-audit.xml (line 165) <https://reviews.apache.org/r/39101/#comment159325> It is not clear what settings to comment and what to uncomment. Perhaps you can list the property names to be commented and uncommented for Azure. Other option is to include Azure specific properties, with empty value (and handle in code appropriately). This will keep the conf file clean and easier to read. Also, note that all this should be documented so that users can configure audit properties via Ambari. - Madhan Neethiraj On Oct. 7, 2015, 7:24 p.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39101/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 7:24 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Madhan Neethiraj, > and Velmurugan Periasamy. > > > Bugs: RANGER-682 > https://issues.apache.org/jira/browse/RANGER-682 > > > Repository: ranger > > > Description > ------- > > Hadoop has added native support for Azure Blob Storage. Ranger allows to > write audit messages to it via Hadoops support for writing to Azure Blob > Storage by existing HDFS Audit Provider. > - Also fixed a issue to reconnect to Filesystem in case of error > - Configuration support added only for v3 style of configuration. > - This patch applies to master. However, it will be ported to Ranger-0.5 > branch, too. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java > 49e5fbb > hbase-agent/conf/ranger-hbase-audit.xml c5f416e > hdfs-agent/conf/ranger-hdfs-audit.xml 4c60c02 > hive-agent/conf/ranger-hive-audit.xml 867080c > knox-agent/conf/ranger-knox-audit.xml ccc2691 > plugin-kafka/conf/ranger-kafka-audit.xml bff6cbf > plugin-kms/conf/ranger-kms-audit.xml f1c4187 > plugin-solr/conf/ranger-solr-audit.xml a42716f > plugin-yarn/conf/ranger-yarn-audit.xml c30f963 > storm-agent/conf/ranger-storm-audit.xml 6a5ff69 > > Diff: https://reviews.apache.org/r/39101/diff/ > > > Testing > ------- > > Write to Azure blob storage via TestEvents utlity > - Microsoft HDInisight currently clusters don't have support for kerberos. > However, testing was done with and without wire encryption (WASB and WASBS > schemas). > > > Thanks, > > Alok Lal > >
