----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39215/#review102387 -----------------------------------------------------------
Ship it! agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java (line 110) <https://reviews.apache.org/r/39215/#comment160022> This change does not look relevant to the current fix..and might impact all audit destinations. Please make sure to verify well. plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java (line 161) <https://reviews.apache.org/r/39215/#comment160021> Consider moving this log level check to logAuthorizationContext() method. The level at which the logging is done is determined by the method impl.. Other option is for the method to return formatted log msg, which can be logged from here. - Madhan Neethiraj On Oct. 12, 2015, 3:55 a.m., Don Bosco Durai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39215/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 3:55 a.m.) > > > Review request for ranger, Madhan Neethiraj and Selvamohan Neethiraj. > > > Bugs: RANGER-657 > https://issues.apache.org/jira/browse/RANGER-657 > > > Repository: ranger > > > Description > ------- > > Updated Ranger Solr Authorization code to address keberos principal > > > Diffs > ----- > > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > a3a3a84 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java > bab496c > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > 8e0ada8 > > Diff: https://reviews.apache.org/r/39215/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Don Bosco Durai > >
