----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39900/#review105243 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java (line 177) <https://reviews.apache.org/r/39900/#comment163767> Assuming this review is really about "New Public API to get server version info" I see too many changes here that do not seem closely related to "get server version info". If you are tyring to fix general issues not specific to "get server version info", would recommend filing separate jiras and commit against them. - dilli dorai On Nov. 5, 2015, 2:44 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39900/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 2:44 p.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan > Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-716 > https://issues.apache.org/jira/browse/RANGER-716 > > > Repository: ranger > > > Description > ------- > > Added a new REST API call to get server version info > > 1) Should return - "statusCode":401,"msgDesc":"Authentication Failed" if user > credentials doesn't match > 2) Should return - Response code : 200, if user credentials matches > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > 689e16596be4ccd3b58061af70943bcf7ec5f66d > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java > 572323f495e1fe01d7f1aed3de59dcb2a9e39bcf > security-admin/src/main/java/org/apache/ranger/common/AppConstants.java > 488ba8ff08c5385eb7306254672592e2c09a3b68 > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java > ae407f12fd1855b3150c46aa3ec7b04723275a8c > > security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java > abf4db4783474a94ffe1f3a24de6aec577982c42 > security-admin/src/main/java/org/apache/ranger/view/RangerServerInfo.java > PRE-CREATION > security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js > 3d33d8678b3069dcdba5ff5536722dc3eaaa90d4 > > Diff: https://reviews.apache.org/r/39900/diff/ > > > Testing > ------- > > Tested with local Ranger setup. > > > Thanks, > > Gautam Borad > >
