Selva, Would like to do that and spend more time on Ranger. However, limited by time constraints due to my commitments to my employer. Would alert dev list if I notice anything that could be improved. Thanks Dilli
On Thu, Nov 5, 2015 at 7:33 AM, Selvamohan Neethiraj <[email protected]> wrote: > +1 > > Definitely will make it easy to review code … > > Thanks for the suggestion Dilli, Would you be able to update the Ranger > Wiki with the good coding practices ? > > Thanks, > Selva- > > From: Dilli Dorai <[email protected]> > Reply-To: "[email protected]" < > [email protected]> > Date: Thursday, November 5, 2015 at 10:26 AM > To: "[email protected]" <[email protected]> > Subject: REST API code review > > Rangers, > > Would like to suggest some good practice while submitting code review for > REST API changes. > > Please include curl calls for success case and failure case and show the > outputs in code review Testing Done section. > > This would make it clear what is being addressed and help to get better > code review. > > Anyone supporting this suggestion? > > Thanks > Dilli > > >
