-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40868/
-----------------------------------------------------------

(Updated Dec. 3, 2015, 5:40 a.m.)


Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan 
Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Addressed review comments


Bugs: RANGER-761
    https://issues.apache.org/jira/browse/RANGER-761


Repository: ranger


Description
-------

**Current Issue :**

Transaction logs not getting generated under audit menu admin tab if policy 
name is changed

** Proposed Solution : **
In every policy update event, will compare policy old name and new name, if 
there is difference in old name and new name then will log the update event in 
x_trx_log table with old policy name and new policy name.


Diffs (updated)
-----

  
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 
d853972 

Diff: https://reviews.apache.org/r/40868/diff/


Testing
-------

**Steps Performed(with patch) :**
1. Created a hdfs policy(mypolicy1) under hadoopdev service.
2. Visited audit menu, audit tab and checked create policy log. Create policy 
log was there.
3. Visited policy manager and then hadoopdev service and then clicked on edit 
button of created policy in step 1(mypolicy1).
4. Changed the name of policy from 'mypolicy1' to 'mypolicy1new'
5. Visited audit menu, audit tab to check new logs related to 'mypolicy1'


**Result/Behavior:**
Update policy log was generated and seen.


Thanks,

Gautam Borad

Reply via email to