----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41080/#review109336 -----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java (line 185) <https://reviews.apache.org/r/41080/#comment168815> Please review addKeyEntry() for a similar breakup of synchronized block: synchronized(deltaEntries) { ... deltaEntries.put(alias.toLowerCase(), entry); keyEntries.put(alias.toLowerCase(), entry); } - Madhan Neethiraj On Dec. 8, 2015, 7:36 a.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41080/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 7:36 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan > Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-773 > https://issues.apache.org/jira/browse/RANGER-773 > > > Repository: ranger > > > Description > ------- > > Patch contains fixes for issues found by coverity scan in Ranger KMS > > > Diffs > ----- > > kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 0def5e5 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 850104f > > Diff: https://reviews.apache.org/r/41080/diff/ > > > Testing > ------- > > Tested for KMS scenarios related to CRUD operation for key and is working > fine. > > > Thanks, > > Gautam Borad > >
