----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42063/#review113786 -----------------------------------------------------------
tagsync/conf.dist/ranger-tagsync-env-setup-hadoop-home.sh (line 23) <https://reviews.apache.org/r/42063/#comment174598> Existing CLASSPATH value will be lost with this assignment. To be safe, handle both cases - 1) CLASSPATH is empty 2) CLASSPATH is not empty agents-installer/src/main/java/org/apache/ranger/utils/install/ConfigPropertyReader.java (line 121) <https://reviews.apache.org/r/42063/#comment174596> XmlConfigChanger - is this class used/needed? - Madhan Neethiraj On Jan. 11, 2016, 8:54 a.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42063/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 8:54 a.m.) > > > Review request for ranger, Abhay Kulkarni and Madhan Neethiraj. > > > Bugs: RANGER-801 > https://issues.apache.org/jira/browse/RANGER-801 > > > Repository: ranger > > > Description > ------- > > Enable tagsync to run in secure mode. Please ignore prior review request for > this change. > - Since kafka clients only work with jass files, this change does > authentication only using jass files. Thanks @Abhay for that feedback during > my offline discussion. > - service command passes the jass file argument during startup. > > > Diffs > ----- > > agents-installer/pom.xml 633da6d > > agents-installer/src/main/java/org/apache/ranger/utils/install/ConfigPropertyReader.java > PRE-CREATION > pom.xml d3a7a99 > src/main/assembly/tagsync.xml 8adc5cc > tagsync/conf.dist/ranger-tagsync-env-setup-hadoop-home.sh c171d2a > tagsync/conf/templates/installprop2xml.properties 101a1ba > tagsync/conf/templates/ranger-tagsync-template.xml 9a88681 > tagsync/scripts/install.properties b5ad580 > tagsync/scripts/ranger-tagsync-services.sh ca82ead > tagsync/scripts/setup.py f7455b8 > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java > e1b5130 > > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java > 7bae973 > > Diff: https://reviews.apache.org/r/42063/diff/ > > > Testing > ------- > > - Modified the tagsync code by hand to write to hdfs in a secure cluster. > - Current junits all work. > > > Thanks, > > Alok Lal > >
