----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44744/#review124083 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java (line 119) <https://reviews.apache.org/r/44744/#comment186421> I think it will be safer to move preCleanup() call into try block. - Madhan Neethiraj On March 17, 2016, 7:25 p.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44744/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 7:25 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-882 > https://issues.apache.org/jira/browse/RANGER-882 > > > Repository: ranger > > > Description > ------- > > Scrub null values from policy resource before policy evaluators use them. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > b864e61 > > Diff: https://reviews.apache.org/r/44744/diff/ > > > Testing > ------- > > Reproduced the problem and tested the fix in an older version of the code. > Checked that WARNING messsages shows up containing the policy id and resource > level to identify the problem source. > > Apache JIRA seems to be down currently. I'll update it with review request > once I can get at it. > > > Thanks, > > Alok Lal > >
