----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45072/#review124958 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java (line 354) <https://reviews.apache.org/r/45072/#comment187664> I generally create a new list and populate it and assign it to the member variable. After that clear the old one. This is helpful in a multi-threaded environment. Otherwise there will be a short window where the list will be empty or partially populated agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerPolicyResourceSignature.java (line 89) <https://reviews.apache.org/r/45072/#comment187667> Not sure what this assert does. The label says == null, but the check is differrent. Same for other 3 checks. This feedback is just FYI. - Don Bosco Durai On March 22, 2016, 11:06 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45072/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 11:06 p.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-873 > https://issues.apache.org/jira/browse/RANGER-873 > > > Repository: ranger > > > Description > ------- > > The patch implements the following: > - Added RangerDataMaskDef to RangerServiceDef, to capture details of the > datamask types supported in the service. > - Added policyType = POLICY_TYPE_DATAMASK, to capture type of datamak to > apply for given users/groups/conditions. > - Added evalDataMaskPolicies() method to policy-engine to evaluate datamask > policies and return type of datamask to apply for the given user and resource. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java > 72f7205 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > 7354dfe > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java > 76d853a > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java > f66839e > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java > 307606f > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java > 381864d > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerDataMaskResult.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java > 02ad9e9 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 92481f6 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > d39dd52 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDataMaskPolicyItemEvaluator.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultDataMaskPolicyItemEvaluator.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 1fa8644 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > 3f76755 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java > 1dfc8cf > > agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerPolicyResourceSignature.java > 8c8c4c0 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java > e0f3b0e > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > f9ba62b > > agents-common/src/test/resources/policyengine/test_policyengine_hive_masking.json > PRE-CREATION > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json > 9c9bc40 > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_filebased.json > e9ee355 > security-admin/db/mysql/patches/020-datamask-policy.sql PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyRetriever.java > 517de20 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 432c443 > security-admin/src/main/java/org/apache/ranger/common/AppConstants.java > e47d10b > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java > d9cf87a > security-admin/src/main/java/org/apache/ranger/db/XXDataMaskTypeDefDao.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyItemDataMaskInfoDao.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/entity/XXAccessTypeDef.java > 72eeb1d > > security-admin/src/main/java/org/apache/ranger/entity/XXDataMaskTypeDef.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/entity/XXPolicyItemDataMaskInfo.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/entity/XXResourceDef.java > 54f716d > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java > b256a92 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java > ee92291 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml a75ca93 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > db958a5 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java > 5c57a9f > > Diff: https://reviews.apache.org/r/45072/diff/ > > > Testing > ------- > > initial version. Verified that existing unit tests pass. > > > Thanks, > > Madhan Neethiraj > >
