----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45074/#review125006 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 23, 2016, 11:01 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45074/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 11:01 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-888 > https://issues.apache.org/jira/browse/RANGER-888 > > > Repository: ranger > > > Description > ------- > > **Problem Statement** > As of now, Delete Users feature is not available in Ranger UI. Ranger Admin > UI should have feature to delete users and groups. Only users having role > 'ADMIN' should be allowed to delete users and groups. > > **Proposed Solution** > > At the UI End have added Delete button in Users and Groups page which can be > used to delete users/groups. > On the click event, Delete button shall call REST '/secure/users/delete' for > User deletion and '/secure/groups/delete' for group deletion. > These REST can accept Users/Groups list in json format and will process each > users/groups by calling existing implementation of Delete Users/Groups in > XUserMgr class. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 5aed040 > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0f5a462 > security-admin/src/main/webapp/scripts/model_bases/VXGroupBase.js 39de8db > security-admin/src/main/webapp/scripts/model_bases/VXUserBase.js c97a425 > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > e2b2f85 > security-admin/src/main/webapp/templates/users/UserTableLayout_tmpl.html > 5d38022 > > Diff: https://reviews.apache.org/r/45074/diff/ > > > Testing > ------- > > **Steps Performed(with patch) :** > 1. After Ranger installation, started Ranger admin and usersync to sync unix > os users. > 2. Logged in Ranger Admin from admin account. > 2. Added user(user1,user2) and group(group1,group2) from users/groups page > 3. Created hdfs policy(policy1) and assigned permissions(READ,WRITE,EXECUTE) > to newly created users and groups. > 4. From permission page assigned module permission to newly created users and > groups. > 5. Deleted user1 and user2 > 6. Deleted group1 and group2 > > **Expected Behaviour :** > After Deleting user1 and user2 it is expected that : > user1 and user2 should be deleted from User page. > user1 and user2 should not appear in policy detail page. > user1 and user2 should not appear permission module page. > user1 and user2 deletion log should appear in Admin tab of Audit menu. > After Deleting group1 and group2 it is expected that : > group1 and group2 should be deleted from Group page. > group1 and group2 should not appear in policy detail page. > group1 and group2 should not appear permission module page. > group1 and group2 deletion log should appear in Admin tab of Audit menu. > > **Actual Behaviour :** > After deleting user1 and user2 it was observed that: > user1 and user2 was deleted from User page. > user1 and user2 was not appearing in policy detail page. > user1 and user2 was not appearing in permission module page. > user1 and user2 deletion log was available in Admin tab of Audit menu. > > After deleting group1 and group2 it was observed that: > group1 and group2 was deleted from Group page. > group1 and group2 was not appearing in policy detail page. > group1 and group2 was not appearing in permission module page. > group1 and group2 deletion log was available in Admin tab of Audit menu. > > > Thanks, > > Pradeep Agrawal > >
