----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45210/#review125037 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java (line 574) <https://reviews.apache.org/r/45210/#comment187792> I now this is existing code, but as a part of this change, should we explicitly set this to "false"? It is just that making a boolean value of "null" seems wrong. - Don Bosco Durai On March 23, 2016, 11:57 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45210/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 11:57 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > Fix PMD "BooleanInstantiation" issues > > > Diffs > ----- > > dev-support/ranger-pmd-ruleset.xml 5dd3851 > security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java > 3f92d8d > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java > 3c0eb95 > security-admin/src/main/java/org/apache/ranger/view/VXPolicy.java 405f7c4 > > Diff: https://reviews.apache.org/r/45210/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
