----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45192/#review125385 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 25, 2016, 1:48 a.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45192/ > ----------------------------------------------------------- > > (Updated March 25, 2016, 1:48 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-891 > https://issues.apache.org/jira/browse/RANGER-891 > > > Repository: ranger > > > Description > ------- > > update assembly for solr plugin so it also includes the hadoop commons jar > needed for this shutdownhook manager. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java > cb998cd > > Diff: https://reviews.apache.org/r/45192/diff/ > > > Testing > ------- > > - Manual testing of HDFS and HS2 plugin. Send kill -3 NN and HS2 while it > was reciving traffic and generating audit messages to verify all stages of > JVMShutdownHook processing happen as expected. > - Verified that assembly files of all plugins does contain hadoop-commons > which contains the shutdownhook manager. > - Verified that new assembly of solr plug in packages hadoop-common under lib > (it already did it for install/lib) > > > Thanks, > > Alok Lal > >
