> On March 31, 2016, 5:04 a.m., Alok Lal wrote: > > ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java, > > line 248 > > <https://reviews.apache.org/r/45481/diff/1/?file=1319070#file1319070line248> > > > > Is change to interface's visibility intended?
No, I've fixed this now. - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45481/#review126267 ----------------------------------------------------------- On March 30, 2016, 10:33 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45481/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 10:33 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > Fix "UnusedModifier" issues > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditHandler.java > 7b51f1d > agents-audit/src/main/java/org/apache/ranger/audit/provider/LogBuffer.java > aebef1b > > agents-audit/src/main/java/org/apache/ranger/audit/provider/LogDestination.java > d6f87cf > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResource.java > 8c1c7c5 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > 25812a4 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java > 9ac2f93 > dev-support/ranger-pmd-ruleset.xml 405c570 > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseAuthUtils.java > 1d487e5 > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/HDFSAccessVerifier.java > 1a0cb0b > jisql/src/main/java/org/apache/util/outputformatter/JisqlFormatter.java > 838225b > > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java > ba4c043 > > ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java > 7bb64b4 > > ranger_solrj/src/main/java/org/apache/solr/common/cloud/BeforeReconnect.java > 44379a4 > ranger_solrj/src/main/java/org/apache/solr/common/cloud/ClosableThread.java > 1a19cbd > ranger_solrj/src/main/java/org/apache/solr/common/cloud/OnReconnect.java > e447982 > > ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkCredentialsProvider.java > b4ab6d8 > > ranger_solrj/src/main/java/org/apache/solr/common/params/AnalysisParams.java > 36c276f > > ranger_solrj/src/main/java/org/apache/solr/common/params/CollectionParams.java > be8906e > ranger_solrj/src/main/java/org/apache/solr/common/params/CommonParams.java > 699059a > > ranger_solrj/src/main/java/org/apache/solr/common/params/CursorMarkParams.java > c20cfd9 > ranger_solrj/src/main/java/org/apache/solr/common/params/DisMaxParams.java > c2c268e > ranger_solrj/src/main/java/org/apache/solr/common/params/EventParams.java > f5d43c0 > ranger_solrj/src/main/java/org/apache/solr/common/params/ExpandParams.java > a8f0cf7 > ranger_solrj/src/main/java/org/apache/solr/common/params/FacetParams.java > 2dae65f > ranger_solrj/src/main/java/org/apache/solr/common/params/GroupParams.java > ca8e2c4 > > ranger_solrj/src/main/java/org/apache/solr/common/params/HighlightParams.java > ceccd74 > > ranger_solrj/src/main/java/org/apache/solr/common/params/MoreLikeThisParams.java > 0d808c2 > ranger_solrj/src/main/java/org/apache/solr/common/params/ShardParams.java > 46a9fc0 > ranger_solrj/src/main/java/org/apache/solr/common/params/SimpleParams.java > e770402 > ranger_solrj/src/main/java/org/apache/solr/common/params/SpatialParams.java > 043f216 > > ranger_solrj/src/main/java/org/apache/solr/common/params/SpellingParams.java > 918592d > ranger_solrj/src/main/java/org/apache/solr/common/params/StatsParams.java > 6fb7935 > > ranger_solrj/src/main/java/org/apache/solr/common/params/TermVectorParams.java > cfa1afd > ranger_solrj/src/main/java/org/apache/solr/common/params/TermsParams.java > 9558efc > ranger_solrj/src/main/java/org/apache/solr/common/params/UpdateParams.java > cf965a9 > ranger_solrj/src/main/java/org/apache/solr/common/util/RetryUtil.java > 83ee100 > security-admin/src/main/java/org/apache/ranger/common/MyCallBack.java > f10c40c > ugsync/src/main/java/org/apache/ranger/usergroupsync/Mapper.java 820fe20 > ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSink.java > 0443185 > ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSource.java > 6dbb83d > > Diff: https://reviews.apache.org/r/45481/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
