> On April 2, 2016, 6:11 a.m., Madhan Neethiraj wrote: > > kms/scripts/db/mysql/kms_core_db.sql, line 27 > > <https://reviews.apache.org/r/45428/diff/1/?file=1318025#file1318025line27> > > > > It will be helpful to retain 'DEFAULT CHARSET=latin1'; some users > > reported errors about index column length when the database was set to > > multi-byte characters.
I removed that because we are not using 'DEFAULT CHARSET=latin1' clause in all tables. For example: table being created from sql patches don't have 'DEFAULT CHARSET=latin1' clause. Reference Link : https://github.com/apache/incubator-ranger/blob/master/security-admin/db/mysql/patches/009-updated_schema.sql We can keep this clause if removal of it can cause issues to users. - Pradeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45428/#review126681 ----------------------------------------------------------- On April 2, 2016, 7:47 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45428/ > ----------------------------------------------------------- > > (Updated April 2, 2016, 7:47 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Ramesh Mani, and Selvamohan Neethiraj. > > > Bugs: RANGER-896 > https://issues.apache.org/jira/browse/RANGER-896 > > > Repository: ranger > > > Description > ------- > > **Problem Statement :** Currently Ranger works with MySQL Database, Since > MariaDB is similar to MySQL; Ranger should work with MariaDB also. > > **Proposed Solution :** > > Proposed attached patch is optional and contains removal of storage engine > type(InnoDB) from all tables where schema has 'ENGINE=InnoDB' clause. > > No mandatory changes are required to support MariaDB. User will have to > provide : > - DB_FLAVOR=MYSQL, > - MariaDB hostname/ip details and > - DB credentials in install.properties file > > The rest of the flow will remain similar to MYSQL. > > > Diffs > ----- > > kms/scripts/db/mysql/kms_core_db.sql 4e7cf29 > security-admin/db/mysql/xa_audit_db.sql 163d7b6 > security-admin/db/mysql/xa_core_db.sql 9d889a0 > > Diff: https://reviews.apache.org/r/45428/diff/ > > > Testing > ------- > > **With and Without patch :** > > Ranger is working fine with MariaDB 5.5.48, 10.0.24 and MySQL 5.6. > > > Thanks, > > Pradeep Agrawal > >
