-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46089/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay
Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan
Periasamy.
Bugs: RANGER-921
https://issues.apache.org/jira/browse/RANGER-921
Repository: ranger
Description
-------
**Problem Statement :**
Currently implementation of XXDataHistDao.findObjByEventTimeClassTypeAndId()
and XXPortalUserDao.findXPortalUserRolebyXPortalUserId() usage native query
which can be converted to JPA named query.
**Proposed Solution :**
Added a jpa named query to filter XXDataHist entries based on eventTime,
ClassType and Id field. Have removed SQL statement rewritting part and replaced
with parameterised named query. similarly list of user's role can be fetched
from x_portal_user_role table by using parameterised named query hence
implementation has been added in XXPortalUserDao class.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/common/DateUtil.java 92150ee
security-admin/src/main/java/org/apache/ranger/db/XXDataHistDao.java 07db458
security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java
393252c
security-admin/src/main/java/org/apache/ranger/db/XXPortalUserRoleDao.java
99d0fe2
security-admin/src/main/java/org/apache/ranger/patch/PatchPersmissionModel_J10003.java
804d08e
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 469a400
Diff: https://reviews.apache.org/r/46089/diff/
Testing
-------
Steps Performed without patch :
1. After starting Ranger service, enabled HDFS plugin and created audit logs.
2. in Ranger Admin UI -> Access Audit logs : clicked on policy id link of
generated audit logs.
3. A screen pop-up with Policy details.
Steps Performed with patch :
1. After starting Ranger service, enabled HDFS plugin and created audit logs.
2. in Ranger Admin UI -> Access Audit logs : clicked on policy id link of
generated audit logs.
3. A screen pop-up with Policy details.
Expected Behavior :
Policy details page should come and policy details page appeared in case of
with and without patch should match.
Actual Behavior :
Policy details page in both cases(with and without patch) was same.
Thanks,
Pradeep Agrawal
