----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45679/#review128979 -----------------------------------------------------------
Fix it, then Ship it! Fix it and ship it! security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java (line 174) <https://reviews.apache.org/r/45679/#comment192429> Instead of the NOPMD tag on this private method can this be merged with its sole public caller (as you have done for XUserMgr.java) and NOPMD tag moved to it instead, please? - Alok Lal On April 13, 2016, 3:44 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45679/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 3:44 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > Fix PMD Unused Formal Parameters > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/DbAuditProvider.java > 8319d36 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java > 0f0e5ee > dev-support/ranger-pmd-ruleset.xml f82d831 > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java > b463da3 > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/agent/HadoopAuthClassTransformer.java > ace400b > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > dbd1201 > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > 151f23e > security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java 551ec2e > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > 5905fc9 > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java ae81b22 > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > cf66fc1 > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > c25b989 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 8f01bfc > > Diff: https://reviews.apache.org/r/45679/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
