[ 
https://issues.apache.org/jira/browse/RANGER-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248304#comment-15248304
 ] 

rangerqa commented on RANGER-936:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  
http://issues.apache.org/jira/secure/attachment/12799534/0001-RANGER-936-Some-junit-related-improvements.patch
  against master revision 702cf84.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-RANGER-Build/171//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-RANGER-Build/171//console

This message is automatically generated.

> Some junit related improvements
> -------------------------------
>
>                 Key: RANGER-936
>                 URL: https://issues.apache.org/jira/browse/RANGER-936
>             Project: Ranger
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>             Fix For: 0.6.0
>
>         Attachments: 0001-RANGER-936-Some-junit-related-improvements.patch
>
>
> There are some junit related changes I'd like to make to Ranger:
> a) Update to 4.12
> b) Make sure junit is defined at test scope in all the modules
> c) Remove it from the assembly files, there should be no need to include test 
> dependencies
> d) Remove it from a few shims where there are no test classes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to