----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46630/ -----------------------------------------------------------
(Updated April 27, 2016, 12:46 p.m.) Review request for ranger. Summary (updated) ----------------- RANGER-949 - Some agents improvements Repository: ranger Description ------- Some agents improvements: a) No need to use lazy init with the associating synchronized hit to load the RangerCredentialProvider. b) The RangerCredentialProviderTest is writing a keystore to the user home directory! This is changed to write to a temporary file instead c) The agents-installer module only needs commons-cli and not the whole hadoop-client set of dependencies d) The "PasswordGenerator" is using Random instead of SecureRandom!!? e) The XmlConfigChanger should be enabling secure processing when parsing into DOM. Diffs ----- agents-cred/src/main/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProvider.java d3faf60 agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java 686318b agents-installer/pom.xml 97837a8 agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java 3632c1a agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 9d0cbed Diff: https://reviews.apache.org/r/46630/diff/ Testing ------- Thanks, Colm O hEigeartaigh
