----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46480/#review130778 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On April 21, 2016, 8:54 a.m., Mehul Parikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46480/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 8:54 a.m.) > > > Review request for ranger, Gautam Borad, Madhan Neethiraj, Pradeep Agrawal, > and Velmurugan Periasamy. > > > Bugs: RANGER-926 > https://issues.apache.org/jira/browse/RANGER-926 > > > Repository: ranger > > > Description > ------- > > **PROBLEM STATEMENT: ** > Ranger currently sets the Last Name and First Name fields from the User Name > field. > However, only space, _ and - is accepted in the Last Name field when trying > to make a sync'd user an Admin. Usernames could be in the form > firstname.lastname meaning they cannot change any users to Admins in the > Ranger Admin interface. It fails with the message > "Last name should start with alphabets & can have underscore, hyphen, space." > **PROPOSED SOLUTION: ** > Please allow . [dot] in First Name and Last name of User (update validation > on UI). > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/common/StringUtil.java > c292fec > security-admin/src/main/webapp/scripts/models/VXPortalUser.js 6d05e8e > security-admin/src/main/webapp/scripts/views/users/UserForm.js 8319901 > > Diff: https://reviews.apache.org/r/46480/diff/ > > > Testing > ------- > > Verified user creation with . [dot] in Firstname and Lastname fields. > > > Thanks, > > Mehul Parikh > >
