[
https://issues.apache.org/jira/browse/RANGER-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262002#comment-15262002
]
rangerqa commented on RANGER-958:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12801211/0001-RANGER-958-HDFS-review.patch
against master revision 415ed43.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
+1 checkstyle. The patch generated 0 code style errors.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-RANGER-Build/189//testReport/
Console output:
https://builds.apache.org/job/PreCommit-RANGER-Build/189//console
This message is automatically generated.
> HDFS review
> -----------
>
> Key: RANGER-958
> URL: https://issues.apache.org/jira/browse/RANGER-958
> Project: Ranger
> Issue Type: Improvement
> Reporter: Colm O hEigeartaigh
> Assignee: Colm O hEigeartaigh
> Priority: Minor
> Fix For: 0.6.0
>
> Attachments: 0001-RANGER-958-HDFS-review.patch
>
>
> Some minor changes following a review of the HDFS code:
> a) Remove unnecessary dependencies in both the HDFS shim + plugin
> b) Some trivial changes to the RangerHdfsAuthorizer - use an empty Set for
> FS.NONE instead of creating a new Set + use an existing constructor for the
> RangerHdfsAccessRequest.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
